Adding NGram range support for feature extraction#2
Closed
madhawa-gunasekara wants to merge 3 commits into
Closed
Conversation
madhawa-gunasekara
force-pushed
the
OPENNLP-844
branch
from
8703ca6 to
d8c16a2
Compare
Contributor
|
+1 to merge |
|
It would be nice to either document behavior, or handle the case where minGram > maxGram (if passed by user mistakenly, for example). |
Contributor
|
good validation step @kelkarn |
Member
Author
|
@kelkarn I will update the PR request. Thanks |
madhawa-gunasekara
force-pushed
the
OPENNLP-844
branch
from
3c21478 to
6376eae
Compare
| this.maxGram = maxGram; | ||
| } else { | ||
| throw new InvalidFormatException("minimum range value (minGram) should be less than or equal to maximum range value (maxGram)!"); | ||
| } |
There was a problem hiding this comment.
This is good, but what if minGram/maxGram are negative?
|
Hey there, we could probably deprecate bag of words and use this one with unigrams
|
Member
Author
|
Closing pull request |
maximestein
pushed a commit
to maximestein/opennlp
that referenced
this pull request
Jan 7, 2019
…ool-close-failure-in-OpenNLP-GIS-class Feature tec 1918 threadpool close failure in open nlp gis class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/OPENNLP-844